Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs(PPDSC-2149): Updated structured-list page link #195

Merged
merged 15 commits into from
May 12, 2022
Merged

docs(PPDSC-2149): Updated structured-list page link #195

merged 15 commits into from
May 12, 2022

Conversation

Srinivasan-Ramasamy
Copy link
Contributor

PPDSC-2149

What

  1. Add "Structured List" docs page to the sidebar.
  2. ToDo: Still illustrations are missing in this page, we will discuss with design team to move forwared.

I have done:

  • Written unit tests against changes
  • Written functional tests against the component and/or NewsKit site
  • Updated relevant documentation

I have tested manually:

  • The feature's functionality is working as expected on Chrome, Firefox, Safari and Edge
  • The screen reader reads and flows through the elements as expected.
  • There are no new errors in the browser console coming from this PR.
  • When visual test is not added, it renders correctly on different browsers and mobile viewports (Safari, Firefox, small mobile viewport, tablet)
  • The Playground feature is working as expected

Before:

After:

Who should review this PR:

How to test:

@github-actions github-actions bot added the docs Improvements or additions to documentation label May 10, 2022
@Srinivasan-Ramasamy Srinivasan-Ramasamy added ready for design review Please assist in getting this reviewed WIP Work in progress labels May 10, 2022
@newskit-engineering
Copy link
Collaborator

You can preview these changes on:
Documentation Site: http://ncu-newskit-docs.s3-website-eu-west-1.amazonaws.com/ppdsc-2149-structured-list
Storybook: http://ncu-newskit-docs.s3-website-eu-west-1.amazonaws.com/ppdsc-2149-structured-list/storybook

@Srinivasan-Ramasamy Srinivasan-Ramasamy added ready for review Please assist in getting this reviewed and removed ready for design review Please assist in getting this reviewed WIP Work in progress labels May 11, 2022
evgenitsn
evgenitsn previously approved these changes May 11, 2022
View reviewed changes
mutebg
mutebg previously approved these changes May 11, 2022
View reviewed changes
@Srinivasan-Ramasamy Srinivasan-Ramasamy dismissed stale reviews from mutebg and evgenitsn via 64bcda4 May 12, 2022 03:21
@Srinivasan-Ramasamy
Copy link
Contributor Author

Thanks @mutebg, @evgenitsn for reviewing the code 👍

@Srinivasan-Ramasamy Srinivasan-Ramasamy merged commit 36fa3f8 into main May 12, 2022
@Srinivasan-Ramasamy Srinivasan-Ramasamy deleted the docs/PPDSC-2149-structured-list branch May 12, 2022 09:24
Xin00163 pushed a commit that referenced this pull request Oct 17, 2022
@Srinivasan-Ramasamy
docs(PPDSC-2149): Updated structured-list page link (#195)
87b34d6 
docs(PPDSC-2149): Updated structured-list page link.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mutebg mutebg mutebg approved these changes

@evgenitsn evgenitsn evgenitsn approved these changes

@jps jps Awaiting requested review from jps

@Xin00163 Xin00163 Awaiting requested review from Xin00163

@pdimova pdimova Awaiting requested review from pdimova

@baburay23 baburay23 Awaiting requested review from baburay23

@Vanals Vanals Awaiting requested review from Vanals

Assignees
No one assigned
Labels
docs Improvements or additions to documentation ready for review Please assist in getting this reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Srinivasan-Ramasamy @newskit-engineering @mutebg @evgenitsn